Add rails smoke tests to external tests. #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
rails-external-tests
branch
2 times, most recently
from
065a42b
to
ef23704
Compare
4 tasks
ioquatix
force-pushed
the
rails-external-tests
branch
from
ef23704
to
4402db5
Compare
jeremyevans
approved these changes
Jun 12, 2024
|
I'm testing rack-head in the Sinatra repo. Currently there is one known failure: sinatra/sinatra#2014 |
ioquatix
force-pushed
the
rails-external-tests
branch
from
4402db5
to
a3c2811
Compare
|
@dentarg are you able to create a PR to add Sinatra to the external tests? |
|
I have too little time right now |
|
Once rails/rails#52096 is merged (or the issue is otherwise resolved), we can merge this. |
I have some. #2210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a couple of challenges relating to what essentially amount to compatibility issues between Rails and Rack, e.g. rails/rails#52066. Let's ensure that Rails' smoke tests all pass as part of Rack's CI. This should give earlier indications about potential issues.