Simplified the URLMapping logic and added case insensitivity to domain matching #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/bump /bump we're still having to run a fork here. |
|
/bump |
| || (!host && (hHost == sName || hHost == sName+':'+sPort)) | ||
| next | ||
| end | ||
| next unless hHost && hHost.casecmp(host).zero? || sName.casecmp(host).zero? if host |
There was a problem hiding this comment.
The port matching logic has been removed here.
|
/bump.... lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we recently ran into a bug and realized that the domain matching in Rack::URLMap is case-sensitive, ahhhhh!!!!
Anyway, I fixed it.
While exercising the tests I realized this bit
(!host && (hHost == sName || hHost == sName+':'+sPort))was a case never hit; is there something that I'm missing/breaking by taking it out? All the tests are green.