Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load session for read before accessing keys or values #981

Merged
merged 2 commits into from Jan 1, 2016

Conversation

michaelsauter
Copy link
Contributor

Is there a specific reason why the session is not loaded for #keys or #values? Looks like it should ...

@tarasstruk
Copy link

👍 Looks fine. These methods are on the same range with #each. If they suppose to be called only if loaded?==true then they should provide a reasonable exception.

@matthewd
Copy link
Contributor

Is there somewhere we can add some tests for this?

@michaelsauter
Copy link
Contributor Author

@matthewd Sorry for the silence on this. I wasn't quite sure where to add tests. It looks like there are none yet for the SessionHash? I made a new test file now (5de59df) which tests the changed behaviour - those tests fail if run without the changes.

matthewd added a commit that referenced this pull request Jan 1, 2016
Load session for read before accessing keys or values
@matthewd matthewd merged commit a7b3c3c into rack:master Jan 1, 2016
@matthewd
Copy link
Contributor

matthewd commented Jan 1, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants