Response#redirect? micro-optimization #986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktheory
force-pushed
the
redirect-set
branch
from
8d104bb
to
f82d23c
Compare
Improve performance of `redirect?` by ~55% using a set instead of an array. See this gist for benchmarks: https://gist.github.com/ktheory/e62bc43900745d54eb4f
ktheory
force-pushed
the
redirect-set
branch
from
f82d23c
to
76d44b6
Compare
|
I'm closing this to clean up old pull requests. I'm happy for someone else to advocate for this change; but it seems pretty fiddly & low-impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the performance of
Response#redirect?by ~55% using a set instead of anarray.
See this gist for benchmarks.
tl;dr: The new method can run a million redirect checks in 151ms, vs. 338ms for the original method (with a
301status, the fastest case).