remove BK. Fixes buildbot#2198.

Fixes buildbot#1773.  Fixes buildbot#891.  Fixes buildbot#1715.

MAINTAINERS.txt

@@ -53,10 +53,6 @@ Git VC
     M: Amber Yust <ayust@yelp.com>
     U: http://trac.buildbot.net/wiki/git
 
-BitKeeper VC
-    S: Last-Rites
-    U: http://trac.buildbot.net/wiki/bk
-
 Darcs VC
     S: Orphaned
     U: http://trac.buildbot.net/wiki/darcs

master/buildbot/steps/source/__init__.py

@@ -14,7 +14,7 @@
 # Copyright Buildbot Team Members
 
 from buildbot.steps.source.oldsource import _ComputeRepositoryURL, Source, CVS, \
-    SVN, Git, Darcs, Repo, Bzr, Mercurial, P4, P4Sync, Monotone, BK
+    SVN, Git, Darcs, Repo, Bzr, Mercurial, P4, P4Sync, Monotone
 
 _hush_pyflakes = [ _ComputeRepositoryURL, Source, CVS, SVN, \
-     Git, Darcs, Repo, Bzr, Mercurial, P4, P4Sync, Monotone, BK ]
+     Git, Darcs, Repo, Bzr, Mercurial, P4, P4Sync, Monotone ]

master/buildbot/steps/source/oldsource.py

@@ -307,78 +307,6 @@ def commandComplete(self, cmd):
 
 
 
-class BK(Source):
-    """I perform BitKeeper checkout/update operations."""
-
-    name = 'bk'
-
-    renderables = [ 'bkurl', 'baseURL' ]
-
-    def __init__(self, bkurl=None, baseURL=None,
-                 directory=None, extra_args=None, **kwargs):
-        """
-        @type  bkurl: string
-        @param bkurl: the URL which points to the BitKeeper server.
-
-        @type  baseURL: string
-        @param baseURL: if branches are enabled, this is the base URL to
-                        which a branch name will be appended. It should
-                        probably end in a slash. Use exactly one of
-                        C{bkurl} and C{baseURL}.
-        """
-
-        self.bkurl = _ComputeRepositoryURL(bkurl)
-        self.baseURL = _ComputeRepositoryURL(baseURL)
-        self.extra_args = extra_args
-
-        Source.__init__(self, **kwargs)
-        self.addFactoryArguments(bkurl=bkurl,
-                                 baseURL=baseURL,
-                                 directory=directory,
-                                 extra_args=extra_args,
-                                 )
-
-        if bkurl and baseURL:
-            raise ValueError("you must use exactly one of bkurl and baseURL")
-
-
-    def computeSourceRevision(self, changes):
-        return changes.revision
-
-
-    def startVC(self, branch, revision, patch):
-
-        warnings = []
-        slavever = self.slaveVersion("bk")
-        if not slavever:
-            m = "slave does not have the 'bk' command"
-            raise BuildSlaveTooOldError(m)
-
-        if self.bkurl:
-            assert not branch # we need baseURL= to use branches
-            self.args['bkurl'] = self.bkurl
-        else:
-            self.args['bkurl'] = self.baseURL + branch
-        self.args['revision'] = revision
-        self.args['patch'] = patch
-        self.args['branch'] = branch
-        if self.extra_args is not None:
-            self.args['extra_args'] = self.extra_args
-
-        revstuff = []
-        revstuff.append("[branch]")
-        if revision is not None:
-            revstuff.append("r%s" % revision)
-        if patch is not None:
-            revstuff.append("[patch]")
-        self.description.extend(revstuff)
-        self.descriptionDone.extend(revstuff)
-
-        cmd = RemoteCommand("bk", self.args)
-        self.startCommand(cmd, warnings)
-
-
-
 class CVS(Source):
     """I do CVS checkout/update operations.
 

master/buildbot/test/regressions/test_oldpaths.py

@@ -193,7 +193,3 @@ def test_steps_source_Monotone(self):
         from buildbot.steps.source import Monotone
         assert Monotone
 
-    def test_steps_source_BK(self):
-        from buildbot.steps.source import BK
-        assert BK
-

master/docs/developer/definitions.rst

@@ -31,7 +31,6 @@ Mercurial   changeset   sha1 hash   different repos
 Darcs       ?           none [2]    different repos
 Bazaar      ?           ?           ?
 Perforce    ?           ?           ?
-BitKeeper   changeset   ?           different repos
 =========== =========== =========== ===================
 
 * [1] note that CVS only tracks patches to individual files.  Buildbot tries to

master/docs/manual/cfg-buildsteps.rst

@@ -1161,25 +1161,6 @@ introduced by a pending changeset.
 Gerrit integration can be also triggered using forced build with ``gerrit_change``
 property with value in format: ``change_number/patchset_number``.
 
-.. bb:step:: BK (Slave-Side)
-
-BitKeeper (Slave-Side)
-++++++++++++++++++++++
-
-The :bb:step:`BK <BK (Slave-Side)>` build step performs a `BitKeeper <http://www.bitkeeper.com/>`_
-checkout or update.
-
-The BitKeeper step takes the following arguments:
-
-``repourl``
-    (required unless ``baseURL`` is provided): the URL at which the
-    BitKeeper source repository is available.
-
-``baseURL``
-    (required unless ``repourl`` is provided): the base repository URL,
-    to which a branch name will be appended. It should probably end in a
-    slash.
-
 .. bb:step:: Repo (Slave-Side)
 
 Repo (Slave-Side)

master/docs/release-notes.rst

@@ -14,11 +14,12 @@ Master
 Deprecations, Removals, and Non-Compatible Changes
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-
 * The configurable callable build.workdir has changed his parameterlist. Instead
   of a single sourcestamp a list of sourcestamps is passed. Each sourcestamp in 
   the list has a different :ref:`codebase<Attr-Codebase>`
-
+
+* BK support has been removed in this release - see :bb:bug:`2198`.
+
 Changes for Developers
 ~~~~~~~~~~~~~~~~~~~~~~
 
@@ -31,6 +32,8 @@ Slave
 Deprecations, Removals, and Non-Compatible Changes
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
+* BK support has been removed in this release - see :bb:bug:`2198`.
+
 Features
 ~~~~~~~~