Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deploy with warning #132

Merged
merged 2 commits into from Oct 21, 2016
Merged

fix deploy with warning #132

merged 2 commits into from Oct 21, 2016

Conversation

rphillips
Copy link
Contributor

  • Bootstrap 3 is not supported by bootstrap-modal
  • Update the CSS and JS to support bootstrap 3

Fixes #123

fix deploy with warning
1804f72 
* Bootstrap 3 is not supported by bootstrap-modal
* Update the CSS and JS to support bootstrap 3
@jjbuchan
Copy link

+1

@mburns
Copy link
Contributor

mburns commented Oct 21, 2016

@rphillips++

@rphillips rphillips merged commit 51293a6 into master Oct 21, 2016
@creationix
Copy link
Contributor

Awesome work!

@mburns mburns deleted the fixes/new_bootstrap_js branch August 1, 2018 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mburns mburns mburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rphillips @jjbuchan @mburns @creationix