Support check.test requests (CMC-1506) #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
commented
Apr 17, 2017
poller/session.go
Outdated
|
|
||
| newCheck, err := check.NewCheckParsed(s.ctx, *req.Params) | ||
| if err != nil { | ||
| resp := protocol.NewErrorResponse(f, 1, "Unable to interpret the given check for testing") |
There was a problem hiding this comment.
@rphillips is there a strategy from virgo agent to define appropriate error code values?
There was a problem hiding this comment.
itzg
commented
Apr 18, 2017
| es := poller.NewSession(context.Background(), eleConn, reconciler, cfg) | ||
| defer func() { time.Sleep(5 * time.Millisecond) }() |
There was a problem hiding this comment.
I was seeing some sporadic unit test failures here...but pushing so I can switch to working on ping/ICMP
added 3 commits
April 20, 2017 08:48
…dd-check-test # Conflicts: # check/checkresult.go
itzg
changed the title
rphillips
reviewed
Apr 24, 2017
| @@ -172,7 +174,11 @@ type MetricTVU struct { | |||
| Unit string `json:"u"` | |||
| } | |||
|
|
|||
| type MetricsPostRequestParams struct { | |||
| func (m *MetricTVU) String() string { | |||
| return fmt.Sprintf("{t=%v, v=%v, u=%v}", m.Type, m.Value, m.Unit) | |||
rphillips
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO