Add sub-context to enable cancellation of checks #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphillips
reviewed
Jan 6, 2017
| @@ -151,7 +151,7 @@ func TestHTTPSuccessBodyMatch(t *testing.T) { | |||
| "target_resolver":"", | |||
| "disabled":false | |||
| }`, ts.URL) | |||
| check := check.NewCheck([]byte(checkData)) | |||
| check := check.NewCheck([]byte(checkData), context.Background(), func() {}) | |||
There was a problem hiding this comment.
can we pass a nil instead of func() {}
There was a problem hiding this comment.
I worried that even though nothing in our tests currently call Check.Cancel()...a later code change might
rphillips
approved these changes
Jan 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@goru97, @tpboudreau , @GeorgeJahad I was looking at the session go-loops and speculated this change might help for check commit/update logic. Feel free to chop it up or rip it out later if not applicable.