Added install instructions to README and simplified provided config structure #89
Conversation
README.md
Outdated
|
|
||
| ### Debian / Ubuntu | ||
|
|
||
| > This installation process is supported on Debian 8 / Ubuntu 15.04 and newer |
There was a problem hiding this comment.
15 sounded old and I found this
As a non-LTS release, 15.04 has a 9-month month support cycle and, as such, the support period is now nearing its end and Ubuntu 15.04 will reach end of life on Thursday, February 4th
That's from 2016. Even if it technically works for 15, is it safer just to put 16.04 which has another year of support?
There was a problem hiding this comment.
I was listing the bare minimum systemd supported versions from
https://en.wikipedia.org/wiki/Systemd#Adoption
however, since this section could easily imply OS versions we support then I like the idea of 16.04 being there.
| Enable and start the service using: | ||
| ```shell script | ||
| sudo systemctl enable telemetry-envoy | ||
| sudo systemctl start telemetry-envoy |
There was a problem hiding this comment.
Is systemctl on all debian things? or is this one of those that will be on some and not others?
There was a problem hiding this comment.
It's on all the versions listed above, as you'll see in the wiki link.
|
|
||
| The service logs can be viewed using: | ||
| ```shell script | ||
| journalctl -f -u telemetry-envoy |
There was a problem hiding this comment.
journalctl is a new command for me
There was a problem hiding this comment.
Yep, it's systemctl's friend for syslog viewing.
pkg/files/telemetry-envoy.yaml
Outdated
| json: | ||
| bind: localhost:8094 | ||
| lineProtocol: | ||
| bind: "" |
There was a problem hiding this comment.
Should this and lumberjack be commented out initially instead?
I keep forgetting what lumberjack is but I don't think we use it most of the time?
There was a problem hiding this comment.
Really lumberjack needs to be ripped out since it was intended for log file gathering, but we have never fully retrofitted for it after the etcd->sql switch.
As for removing it, I would need to look closer at how the defaults are working. Viper config stuff is annoying to interpret.
There was a problem hiding this comment.
...and line protocol is there to allow for customers to proxy their own metrics envoy if they want. I think I found how to default these to "", so I'll do that for both.
Resolves
https://jira.rax.io/browse/SALUS-963
What
The Envoy README was missing installation instructions.
How
How to test
Do a local
make snapshot, copy the deb/rpm over to a VM, and use the install procedure.To copy the file over I used gcloud's scp subcommand, such as: