Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase code coverage - SQL Builder #337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase code coverage - SQL Builder #337

wants to merge 1 commit into from

Conversation

kavishkhanna
Copy link

No description provided.

AJStieren
AJStieren requested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@AJStieren AJStieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing mixed conventions for function names. Make sure your functions begin with lower case letters (I understand the conventions were already mixed, feel free to correct if you have time).

Otherwise changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AJStieren AJStieren AJStieren requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kavishkhanna @AJStieren