styles(dropdown) update default dropdown, inverse, primary #57
Conversation
|
FYI: Carets were dropped from Canon as part of the nav redesign. |
| color: #ccc; | ||
| padding-bottom: 3px; | ||
| padding-top: 3px; | ||
| .font-smoothing; | ||
|
|
||
| .fa-external-link, |
There was a problem hiding this comment.
What's wrong with the default size, margin, etc? Is this a place where we can give up a small of amount of customization in favor of sticking with Bootstrap?
There was a problem hiding this comment.
@bradgignac it's too close to the link text. It reminds me of what @annwa said about the icon within the tabs. I'm good to remove it. Safer to remove and add later.
eddywashere
force-pushed
the
update-dropdown-styles
branch
2 times, most recently
from
bff2429
to
8cba93a
Compare
| } | ||
|
|
||
| .navbar-nav > li > & { | ||
| border-top-right-radius: 3px; |
There was a problem hiding this comment.
This is good without prefixes, right?
There was a problem hiding this comment.
@bradgignac bootstrap has mixins that just reference vendorless border-radius(-x-x). interestingly enough, we can't access those mixins because we have a file in our less folder called mixins
|
|
eddywashere
force-pushed
the
update-dropdown-styles
branch
from
8cba93a
to
becce3d
Compare
styles(dropdown) update default dropdown, inverse, primary
The scope of this pr is to update default styles for dropdowns and accommodate any content we had in canon canon (captions).
Normally there are two styles of dropdowns in bootstrap, .dropdown-menu & .dropdown-inverse.dropdown-menu. I’ve added
.navbar-primary .dropdown-menuto have the original primary nav dropdown style for those that need it.Check it:
Tiny note re: primary nav dropdown. I didn’t bother to fix positioning. I think I’d like to tackle that in another pr and maybe address the caret issue as well.