Add new methods for private network monitoring zones #53
Conversation
|
Your content preview is now ready. 🙇 |
| | | |:ref:`Get your credentials <get-credentials>` | | ||
| +-----------------+----------------+-----------------------------------------------+ | ||
|
|
||
| .. note:: This operation does not accept a request body. |
There was a problem hiding this comment.
Don't need this note since the request does have a body.
There was a problem hiding this comment.
...and the body only requires a label field of type string that is the same concept as labels on our other objects.
There was a problem hiding this comment.
Removed note and added sentence under the Example title about the label field.
|
|
||
| .. code:: | ||
|
|
||
| { |
There was a problem hiding this comment.
An example would be:
{
"label": "Zone A Information"
}| Response | ||
| -------- | ||
|
|
||
| **Example Create a private monitoring zone: JSON response** |
| .. code:: | ||
|
|
||
| { | ||
| <!--Todo: process Request example --> |
There was a problem hiding this comment.
An example would be:
{
"label": "Zone A Updated Information"
}| Response | ||
| -------- | ||
|
|
||
| The following operation does not return a response body. |
There was a problem hiding this comment.
Should it be "This operation" instead of "The following operation"?
|
Your content preview is now ready. 🙇 |
|
Thanks, @itzg. Updates made. Please review at https://staging.developer.rackspace.com/build-29b7dc0b92/docs/rackspace-monitoring/v1/api-reference/zones-operations/#monitoring-zones. I also removed some notes about a request body not being accepted in a couple of other method descriptions where there was actually an example request body given under the note. I was on PTO last week, hence the late application of your review comments. Please re-review and let me know if you have other changes. If not, when would you like to merge this PR based on your product release of these new methods? |
|
Thanks for the quick review, @itzg! Please let me know when you are ready to merge this PR and make these new methods available externally in the docs. |
|
I'm ready when you are :) |
|
Merging now, @itzg. |
|
New docs available externally now - https://developer.rackspace.com/docs/rackspace-monitoring/v1/api-reference/zones-operations/ @itzg |
Fix issue #52
Draft from information available at this time. Used existing POST, PUT, and DELETE API operations to model the 3 new methods.
Still need example requests and responses.