Skip to content
This repository has been archived by the owner on Jul 28, 2021. It is now read-only.

Additional reduction in API call / usage #5

Open
martinb3 opened this issue Oct 7, 2016 · 0 comments
Open

Additional reduction in API call / usage #5

martinb3 opened this issue Oct 7, 2016 · 0 comments

Comments

@martinb3
Copy link
Contributor

martinb3 commented Oct 7, 2016

Maybe we can serialize within a region, or limit the calls we make in one sitting. Ideally, we'd prevent touching so many snapshots during the 'create' run. Since we only clean every 6 hours, I don't think that one is as impactful, unless there's a lot of snapshots (and since that's already serialized in a region, we'd have to add sleeps to get that to reduce API calls).

martinb3 added a commit that referenced this issue Oct 10, 2016
- Pass the instance data from `describe_instances` to the SNS topic

- If we get instance data on the SNS topic, use it instead of looking it all up again

- Sanitize instance data; it may contain un-JSON-serializable values like datetime(s)

RE: #5
martinb3 added a commit that referenced this issue Oct 12, 2016
- Reduce the API footprint of utils#calculate_relevant_tags. It now accepts existing tags vs. looking them up itself.
- Pass existing tags for the instances to the method above. We still have to lookup volumes (to get their tags), but this should help.

RE: #5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant