Button refactoring #365
Button refactoring #365
Conversation
| &:focus { | ||
| background: @buttonNegativeBgHover; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
are you missing a } somewhere in here?
There was a problem hiding this comment.
Nope, had to read the full file
|
So if Travis lets you, then LGTM |
BREAKING CHANGE: This change includes an overhaul of the button styles. **Removes the 'primary', 'button-blue', and 'button-green' styles** - Default button color remains blue. - Added new 'button-positive' class for green button and 'button-negative' class for red button. - Moved all button styles into 'rxButton' directory for consistency
|
Changes Unknown when pulling 0184956 on 277-buttons into * on v1.0.0*. |
|
FINALLY PASSED! |
| @@ -49,6 +55,7 @@ | |||
| @tableCellText: #555; | |||
|
|
|||
| @buttonText: @white; | |||
| @buttonDisabledText: #f0efef; | |||
|
|
|||
| @orangeText: #ffa61b; | |||
There was a problem hiding this comment.
Nitpicking: any context for orangeText? Could this be more semantic?
There was a problem hiding this comment.
It's used for the 'send feedback' link in rxApp, but it's hard to make this one "semantic" without tying it solely to that link. I have trouble with semantics and the vars.less file all together, since there is a lot of fuzziness to it all. Suggestions welcome!
There was a problem hiding this comment.
Fair concern, but it's a little jarring to go buttoncolor, bordercolor, ORANGE, you know? Maybe menuEmphasisText or some derivitive?
There was a problem hiding this comment.
Yep, I get the same feeling here. Maybe lightEmphasisText or linkWithDarkBgText to point out that it's for a dark bg?
There was a problem hiding this comment.
I'd go with the former, although the person that will use this the most is probably you, so something that won't help you forget*
- Besides Orange ;)
There was a problem hiding this comment.
slightyOrangeTextUsedForMakingTextOrange it is!
BREAKING CHANGE: This change includes an overhaul of the button styles.
Removes the 'primary', 'button-blue', and 'button-green' styles
/cc @mocha @ericw