adding bash_completion logic

[komish]

Provides bash_completion functionality should someone find themselves using this via the cli for any reason.

Functionality should remove a short-flag if the corresponding long-flag has been called. Also should work if an argument takes a value.

Demonstration:

$ kthresher -<tab><tab>
--config            --help              --show-autoremoval  -H                  -d                  -p
--dry-run           --keep              --verbose           -V                  -h                  -s
--headers           --purge             --version           -c                  -k                  -v
$ kthresher --verbose -<tab><tab>
--config            --help              --show-autoremoval  -V                  -h                  -s
--dry-run           --keep              --version           -c                  -k
--headers           --purge             -H                  -d                  -p
$ kthresher --verbose -c file -<tab><tab>
--dry-run           --keep              --version           -d                  -p
--headers           --purge             -H                  -h                  -s
--help              --show-autoremoval  -V                  -k
$ kthresher --verbose -c file --dry-run

Did not specify install location, leaving it up to user or maintainer preference on whether it should be installed automatically or not.

[tonyskapunk]

@komish thanks for the PR, I'll review and provide feedback as soon as I can.

[tonyskapunk]

Sorry it took me forever to review this code, added some comments for it.

[tonyskapunk]

Please make it fit in 80c, e.g.

local opts
opts="--help,-h --config,-c --dry-run,-d --headers,-H --keep,-k --purge,-p "
opts+="--show-autoremoval,-s --verbose,-v --version,-V"

[tonyskapunk]

Please do the for loop semi-multi-line use if and use {} on all variable references, to be consistent all across the code, e.g.

for e in "${@:2}"; do
  if [[ "${e}" == "${1}" ]]; then
    return 0
  fi
done

[tonyskapunk]

{} on variable

[tonyskapunk]

{} on variable

[tonyskapunk]

This can be rewriten as:

containsElement "${1}" "${COMP_WORDS[@]}"
result_one="${?}"

[komish]

Went with the alternate suggested path here.

[tonyskapunk]

OR written like this

if ! $( containsElement "${1}" "${COMP_WORDS[@]}" ) &&
   ! $( containsElement "${2}" "${COMP_WORDS[@]}" ); then

[tonyskapunk]

{} on variable

[tonyskapunk]

{} on variable

[komish]

updated to include stylistic elements as requested.

[tonyskapunk]

Few minor things

[tonyskapunk]

is that extra `` a typo?

[komish]

Indeed, I'll sort this out and resubmit.

[tonyskapunk]

The comments I did was on the if statement, I see that has been changed as suggested, great!, minor think with && there is no need for \ at the end of the line when having &&, || or | so one less char there :) .

What I missed in the first review is the assignment of not_used, is there any reason why two assignments are after each other? instead of appending both elements at once? e.g.

not_used="${not_used} ${1} ${2}"

[komish]

I've removed the extraneous \ - I also tried moving the && to the next line and leaving the \ back in as I feel that is probably more logical to the brain but the former looked easier to read so ultimately went with that suggestion.

I don't see a visible difference in functionality between append the new values in one line vs in two, I'm made that adjustment as well. PR update incoming.

[tonyskapunk]

Please squash your commits into a single one, thanks!!!! 💃

[tonyskapunk]

Closing as #50 takes care of it, (same changes, jus squashed) thanks @komish !!