Py2app 88 #103

derwolfe · 2014-11-09T20:44:21Z

Pushing the first stages of the commit. As of right now, py2app will build the application, but when run, it will fail with the following error:

11/9/14 8:36:46.890 AM mimic[39596]: ImportError: No module named syslog
11/9/14 8:45:41.470 AM mimic[40056]: File "twisted/python/syslog.pyc", line 11, in

I'm pretty sure this is related to how my start-app.py script is working.

Also this has no tests, which will obviously need to change.

derwolfe · 2014-11-09T20:49:45Z

related to issue #88

coveralls · 2014-11-12T00:42:17Z

Coverage remained the same when pulling fac1cf5 on derwolfe:py2app-88 into 86e9dd9 on rackerlabs:master.

coveralls · 2014-12-11T10:23:28Z

Coverage remained the same when pulling 092f20c on derwolfe:py2app-88 into c26e5c3 on rackerlabs:master.

coveralls · 2014-12-15T02:55:06Z

Coverage remained the same when pulling 3488f54 on derwolfe:py2app-88 into c26e5c3 on rackerlabs:master.

coveralls · 2014-12-16T01:08:36Z

Coverage increased (+0.02%) when pulling 8586739 on derwolfe:py2app-88 into c26e5c3 on rackerlabs:master.

derwolfe · 2014-12-17T16:12:44Z

Also - my apologies for not TDDing this. If I get some time, I'll try to add some test coverage for run-tests.py and start-app.py

coveralls · 2014-12-18T15:48:04Z

Coverage increased (+0.02%) when pulling 4d8f68f on derwolfe:py2app-88 into c26e5c3 on rackerlabs:master.

coveralls · 2014-12-18T15:50:44Z

Coverage increased (+0.02%) when pulling 4d8f68f on derwolfe:py2app-88 into c26e5c3 on rackerlabs:master.

coveralls · 2014-12-18T16:31:21Z

Coverage increased (+0.02%) when pulling 026d400 on derwolfe:py2app-88 into c26e5c3 on rackerlabs:master.

coveralls · 2014-12-18T17:19:55Z

Coverage increased (+0.02%) when pulling f570897 on derwolfe:py2app-88 into c26e5c3 on rackerlabs:master.

coveralls · 2014-12-18T18:32:35Z

Coverage increased (+0.02%) when pulling aa91191 on derwolfe:py2app-88 into c26e5c3 on rackerlabs:master.

derwolfe · 2014-12-19T02:23:41Z

This was just rebased against master, so it should have the most recent plugins.

coveralls · 2014-12-19T02:42:13Z

Coverage remained the same when pulling 150ca69 on derwolfe:py2app-88 into 402715c on rackerlabs:master.

derwolfe · 2014-12-19T14:30:47Z

I need to add a note to the docs about the fact that this requires a brewed or non-system python to be used.

lekhajee · 2014-12-19T20:00:32Z

docs/development/getting-started.rst

+   (venv)$ pip install -r dev-requirements.txt
+   (venv)$ pip install -r py2app-requirements.txt
+
+The to build the the application, run ``make`` from the root directory.


nit: Then to build the application

@lekhajee Thanks for noticing this - I've fixed it.

coveralls · 2014-12-19T20:32:07Z

Coverage remained the same when pulling 26e4617 on derwolfe:py2app-88 into 402715c on rackerlabs:master.

derwolfe · 2014-12-19T22:02:04Z

Just as an FYI - I'm going to be on vacation until next Friday, so I'll have sporadic access to email.

coveralls · 2014-12-29T13:45:05Z

Coverage remained the same when pulling 8b99a79 on derwolfe:py2app-88 into 402715c on rackerlabs:master.

derwolfe · 2014-12-30T15:06:30Z

I'm going to try to setup tox to run the builder, then I'll put this up for review.

glyph · 2014-12-30T17:54:54Z

Fantastic. Thanks.

derwolfe · 2014-12-31T04:38:32Z

In order to get travis to build the application using an OSX builder, there is a feature flag that needs to be enabled manually by travis's staff. They ask that you send them an email requesting the OSX builder feature be turned on. The steps are detailed at http://docs.travis-ci.com/user/multi-os/#Manual-intervention-required.

If this is ok, could you @glyph or @lekhajee send an email to them asking them to turn the feature on?

Thanks!

derwolfe · 2015-03-04T01:28:06Z

It looks like it (it being the py2app portion of setup.py) isn't pulling in the mimic/twisted/plugins/mimic.py file.

glyph · 2015-03-04T01:43:55Z

Could this be because we added the --develop option to tox in b4f61dd in order to get the coverage report to accurately reflect the plugin file being imported?

derwolfe · 2015-03-04T01:44:40Z

I'm pretty sure it isn't - it is happening locally as well.

glyph · 2015-03-04T01:46:28Z

Hrm. But only after merging master?

glyph · 2015-03-04T01:49:11Z

Now I'm getting this: https://gist.github.com/glyph/fcc354d38222dd9d4ae0

derwolfe · 2015-03-04T01:49:16Z

It looks this is the commit that introduced the change: b71c72f

derwolfe · 2015-03-04T01:50:41Z

Do you get the same error if you run ./build-app.sh?

glyph · 2015-03-04T01:55:33Z

No, then I get exceptions.ImportError: No module named mimic, same as on travis…

glyph · 2015-03-04T02:00:03Z

Looking inside site_packages.zip, I don't even see twisted's own plugins:

★ unzip -l dist/mimic.app/Contents/Resources/lib/python2.7/site-packages.zip | grep twisted/plugins
      499  03-03-15 17:58   twisted/plugins/__init__.pyc
     9751  03-03-15 17:58   twisted/plugins/dropin.cache

derwolfe · 2015-03-04T02:00:37Z

Yes - I just found that as well! It looks like it generates a dropin.cache, but nothing else..

glyph · 2015-03-04T02:03:04Z

It's possible that --system-site-packages is causing some confusion. Have you had any better luck with your own pyobjc?

glyph · 2015-03-04T02:05:23Z

Without --system-site-packages, I'm back to the scan_code error.

derwolfe · 2015-03-04T02:09:13Z

With the scan_code error, which version of py2app are you running? If I remember correctly, newer versions of py2app have an issue. I need to pin the py2app dependencies, instead of just minimum requirements.

glyph · 2015-03-04T02:17:23Z

Yeah, I was just messing around with py2app versions…

glyph · 2015-03-04T02:18:12Z

I think the version with the error was 0.9?

glyph · 2015-03-04T02:19:35Z

When pinning it to 0.8.1, I now get this at the end of the test run:

+ python setup.py py2app
Traceback (most recent call last):
  File "setup.py", line 8, in <module>
    from py2app.build_app import py2app
  File "/Users/glyph/Projects/Mimic/venv-app/lib/python2.7/site-packages/py2app/__init__.py", line 31, in <module>
    __version__ = pkg_resources.require('py2app')[0].version
  File "/Users/glyph/Projects/Mimic/venv-app/lib/python2.7/site-packages/pkg_resources/__init__.py", line 918, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/Users/glyph/Projects/Mimic/venv-app/lib/python2.7/site-packages/pkg_resources/__init__.py", line 810, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (modulegraph 0.10.4 (/Users/glyph/Projects/Mimic/venv-app/lib/python2.7/site-packages), Requirement.parse('modulegraph>=0.11'), set(['py2app']))
+ ./dist/mimic.app/Contents/MacOS/run-tests
build-app.sh: line 33: ./dist/mimic.app/Contents/MacOS/run-tests: No such file or directory

derwolfe · 2015-03-04T02:24:17Z

I'm now getting odd framework python build errors on my machine.

glyph · 2015-03-04T02:25:03Z

I think one thing that might be screwing it up is the fact that if py2app is available at all, the setup.py no longer provides any of the other necessary build metadata to the build process, such as package_dir or packages.

glyph · 2015-03-04T02:39:04Z

I am deeply confused. py2app appears to have regressed in some way since the last time I was looking at this; and not just regressed in its current version, but older versions are broken too. I really don't understand what is going on, but clearly that AttributeError is a py2app bug and we should report it.

derwolfe · 2015-03-04T03:47:49Z

I'm quite confused myself. One way or another, I'm now getting the following error, using the same steps as before.

2015-03-03 21:46:09.077 run-tests[33926:88303] A Python runtime not could be located. You may need to install a framework build of Python, or edit the PyRuntimeLocations array in this application's Info.plist file.

The env is still being built using the system python too.

…to be specified

glyph · 2015-03-04T04:41:29Z

one of the many bugs blocking us seems to be https://bitbucket.org/ronaldoussoren/py2app/issue/156/virtualenvpy-recipe-calls-methods-renamed so I've commented there...

glyph · 2015-03-04T05:20:36Z

Since that bug is in the virtualenv recipe, I have now been messing around with using --user installation to get things set up instead of a virtualenv. I'm getting a little further, but still having trouble generating the plugin.cache and getting it into the zip file.

lekhajee · 2015-03-11T22:29:15Z

Merged #191, which includes all the commits from this PR. Closing this. Thanks!

glyph added the work in progress label Nov 10, 2014

derwolfe force-pushed the py2app-88 branch from 0ad5b8f to fac1cf5 Compare November 11, 2014 23:06

derwolfe force-pushed the py2app-88 branch from fac1cf5 to 3646cfa Compare November 19, 2014 01:40

derwolfe force-pushed the py2app-88 branch from c39ab9f to 092f20c Compare December 10, 2014 23:04

derwolfe force-pushed the py2app-88 branch from 092f20c to c26bfb6 Compare December 11, 2014 14:01

derwolfe force-pushed the py2app-88 branch from 51bcdc3 to 1c65b1f Compare December 19, 2014 02:22

derwolfe mentioned this pull request Dec 19, 2014

make a mac application bundle out of mimic #88

Closed

lekhajee reviewed Dec 19, 2014
View reviewed changes

derwolfe force-pushed the py2app-88 branch from 0521694 to ee81996 Compare December 31, 2014 04:02

derwolfe force-pushed the py2app-88 branch from 9026766 to 35be1da Compare December 31, 2014 04:44

pin py2app and its dependencies to osx 10.10 versions

42c8017

when using the system python, semi-standalone and site-packages need …

aa750b6

…to be specified

glyph mentioned this pull request Mar 4, 2015

Mac app redux #191

Merged

lekhajee closed this Mar 11, 2015

derwolfe removed their assignment Apr 30, 2015

glyph mentioned this pull request Nov 2, 2015

Spike for extracting cleanup logic to separate classes twisted/twisted#58

Closed

ronaldoussoren mentioned this pull request Jan 14, 2020

virtualenv.py recipe calls methods renamed in latest modulegraph ronaldoussoren/py2app#156

Closed

Py2app 88 #103

Py2app 88 #103

Conversation

derwolfe commented Nov 9, 2014

derwolfe commented Nov 9, 2014

coveralls commented Nov 12, 2014

coveralls commented Dec 11, 2014

coveralls commented Dec 15, 2014

coveralls commented Dec 16, 2014

derwolfe commented Dec 17, 2014

coveralls commented Dec 18, 2014

coveralls commented Dec 18, 2014

coveralls commented Dec 18, 2014

coveralls commented Dec 18, 2014

coveralls commented Dec 18, 2014

derwolfe commented Dec 19, 2014

coveralls commented Dec 19, 2014

derwolfe commented Dec 19, 2014

lekhajee Dec 19, 2014

Choose a reason for hiding this comment

derwolfe Dec 19, 2014

Choose a reason for hiding this comment

coveralls commented Dec 19, 2014

derwolfe commented Dec 19, 2014

coveralls commented Dec 29, 2014

derwolfe commented Dec 30, 2014

glyph commented Dec 30, 2014

derwolfe commented Dec 31, 2014

derwolfe commented Mar 4, 2015

glyph commented Mar 4, 2015

derwolfe commented Mar 4, 2015

glyph commented Mar 4, 2015

glyph commented Mar 4, 2015

derwolfe commented Mar 4, 2015

derwolfe commented Mar 4, 2015

glyph commented Mar 4, 2015

glyph commented Mar 4, 2015

derwolfe commented Mar 4, 2015

glyph commented Mar 4, 2015

glyph commented Mar 4, 2015

derwolfe commented Mar 4, 2015

glyph commented Mar 4, 2015

glyph commented Mar 4, 2015

glyph commented Mar 4, 2015

derwolfe commented Mar 4, 2015

glyph commented Mar 4, 2015

glyph commented Mar 4, 2015

derwolfe commented Mar 4, 2015

glyph commented Mar 4, 2015

glyph commented Mar 4, 2015

lekhajee commented Mar 11, 2015