Create a common module for shared rackspace monitoring functionality #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'll try find some time to go through this in the next few weeks |
|
@jon-walton bump. If you're still strapped for time, I can have someone here review it and I can merge myself? |
| if entity.agent_id in active_servers] | ||
|
|
||
|
|
||
| def add_entity_checks(entities, check_type, metric_name, check_config={}, |
There was a problem hiding this comment.
I'm not a fan of the mutable default argument check_config={} can pyrax handle a None for check_type in create_check() ? if not, maybe give pyrax check_type=check_type or {}
|
@eljrax sorry I completely forgot. looks fine apart from that mutable default arg |
|
Fair comment! This is only ever called once, and both modules using it sets the default, so this never popped up. Changed to None, since pyrax handles that fine. |
eljrax
added a commit
that referenced
this pull request
Oct 12, 2015
Create a common module for shared rackspace monitoring functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stab at removing the duplicated code from core_plugins/raxmon.py and core_plugins/raxmon_autoscale.py and moving it to a shared module.