use default args if no args are passed #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am using this and importing it in my own class. The only way that it should be empty (and this class being used) is if you are manually loading extensions, so this shouldn't affect anyone that just uses novaclient.v1_1.servers directly, unless they manually load these portions. You can also disable them by putting public: False and service_net: False into the kwargs passed to the servers.create() function
|
Definitely seeing your use case here. This was defaulting to "None". |
rgbkrk
added a commit
that referenced
this pull request
Aug 22, 2014
use default args if no args are passed
|
Released this as part of 0.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this and importing it in my own class. The only way that it
should be empty (and this class being used) is if you are manually
loading extensions, so this shouldn't affect anyone that just uses
novaclient.v1_1.servers directly, unless they manually load these
portions. You can also disable them by putting public: False and
service_net: False into the kwargs passed to the servers.create()
function.
For use over in my own shell class.
saltstack/salt#15120