Merge pull request #180 from rackerlabs/issue-179

Added logic for SiteSerializer when handling email_scan_alerts and em…
rackerlabs · Feb 26, 2020 · 42c71b8 · 42c71b8
2 parents b3be7c3 + c9d65f9
commit 42c71b8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/master/django_scantron/__init__.py b/master/django_scantron/__init__.py
@@ -1 +1 @@
-__version__ = "1.21"
+__version__ = "1.22"
diff --git a/master/django_scantron/api/serializers.py b/master/django_scantron/api/serializers.py
@@ -63,12 +63,14 @@ def validate(self, attrs):
                 invalid_targets = ",".join(targets_dict["invalid_targets"])
                 raise serializers.ValidationError(f"Invalid excluded targets provided: {invalid_targets}")
 
-        # Email scan alerts and email addresses.
-        email_scan_alerts = attrs["email_scan_alerts"]
-        email_alert_address = attrs["email_alert_address"]
+        # Email scan alerts and email address.
+        if ("email_scan_alerts" in attrs) and ("email_alert_address" in attrs):
 
-        if email_scan_alerts and not email_alert_address:
-            raise serializers.ValidationError(f"Provide an email address if enabling 'Email scan alerts'")
+            email_scan_alerts = attrs["email_scan_alerts"]
+            email_alert_address = attrs["email_alert_address"]
+
+            if email_scan_alerts and not email_alert_address:
+                raise serializers.ValidationError(f"Provide an email address if enabling 'Email scan alerts'")
 
         return attrs