_read_lock sometimes has no responses. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 from me |
dreid
added a commit
that referenced
this pull request
Aug 1, 2013
_read_lock sometimes has no responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is possibly because between the write and the read the TTL may have expired, it could also be a general consistency issue.
This change causes
_verify_lockto raise aNoLockClaimsErrorand foracquireto retry on said error._verify_lockfirst releases it's claim because if this is caused by a consistency problem we can't guarantee that the row won't then exist on the later read. It should be safe to always DELETE even if no valid claim exists.