Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFR: Improved Logging #16

Merged
merged 6 commits into from
Jan 13, 2014
Merged

RFR: Improved Logging #16

merged 6 commits into from
Jan 13, 2014

Conversation

russellhaering
Copy link
Contributor

This branch:

  1. Configures structlog to actually log
  2. Pulls in an updated teeth-rest to support access logging
  3. Adds logging of heartbeats

@@ -169,6 +172,7 @@ def run(self):
interval_multiplier = random.uniform(self.min_jitter_multiplier,
self.max_jitter_multiplier)
interval = (next_heartbeat_by - time.time()) * interval_multiplier
self.log.info('sleeping before next heatbeat', interval=interval)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heatbeat -> heartbeat

@jimrollenhagen
Copy link
Contributor

Except that typo, +1

russellhaering added a commit that referenced this pull request Jan 13, 2014
@russellhaering russellhaering merged commit feda043 into master Jan 13, 2014
@jimrollenhagen jimrollenhagen deleted the improved_logging branch March 21, 2014 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants