RFR: Pluggable Hardware Managers #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
russellhaering
added a commit
that referenced
this pull request
Jan 22, 2014
RFR: Pluggable Hardware Managers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this is to be able to install an arbitrary python module capable of providing the
BaseHardwareManagerinterface, and have the agent find it, test its suitability, and use it if it is the most suitable. This way, someone operating Teeth can add hardware-specific logic without needing to modify the agent (although we might want to start accepting some such plugins upstream).I'm not at all sold on the actual way it works, today my goal is just:
BaseHardwareManagerthat provides sane functionality for most hardware