[doc] on-lexer-valid says "Augments <method not found>"

[sorawee]

I think the title is clear enough. Here's a link to the doc: https://docs.racket-lang.org/framework/Color.html?q=classify-position#%28meth._%28%28%28lib._framework%2Fmain..rkt%29._color~3atext~3c~25~3e%29._on-lexer-valid%29%29

[spdegabrielle]

is this caused by the [valid? boolean?] parameter in @defmethod in line 373?

@defmethod[#:mode augment (on-lexer-valid [valid? boolean?]) any]{

Should it be ?

@defmethod[#:mode augment (on-lexer-valid [valid boolean?]) any]{

https://github.com/racket/gui/blob/master/gui-doc/scribblings/framework/color.scrbl#L373

  @defmethod[#:mode augment (on-lexer-valid [valid? boolean?]) any]{
    This method is an observer for when the lexer is working.  It is called
    when the lexer's state changes from valid to invalid (and back).  The
    @racket[valid?] argument indicates if the lexer has finished running over
    the editor (or not).

    The default method just returns @racket[(void?)].
  }

renders as

[sorawee]

Pretty sure it should be #:mode pubment instead.

[sorawee]

Here's a list of "method not found" problems in other places:

• https://docs.racket-lang.org/tools/drracket_unit.html (4 issues)
• https://docs.racket-lang.org/tools/drracket_language.html (14 issues)
• https://docs.racket-lang.org/tools/drracket_rep.html (1 issue)
• https://docs.racket-lang.org/framework/Racket.html (1 issue)
• https://docs.racket-lang.org/framework/Frame.html (4 issues)

[spdegabrielle]

Pretty sure it should be #:mode pubment instead.

Better to test it if you are unsure?

Steps:

1. raco pkg update --clone <PKG>
2. fork the racket/ repo on GitHub
3. add your fork as a remote: git remote add fork https://github.com/<YOUR-USERNAME>/<PKG>
4. make a new branch, git checkout -b my-edits
5. do edits
6. rebuild documentation using scribble colour.scrbl or raco pkg update gui
7. commit changes, git commit
8. push to the fork, git push fork my-edits
9. create a pull request on GitHub

https://blog.racket-lang.org/2017/09/tutorial-contributing-to-racket.html

[sorawee]

The above two commits/PRs should fix everything except the four issues on https://docs.racket-lang.org/tools/drracket_unit.html, which I still couldn't figure out what went wrong.

[sorawee]

@rfindler could you reopen the issue? There're still issues on https://docs.racket-lang.org/tools/drracket_unit.html and the pending PR for racket/gui. Thanks!

[rfindler]

Oh, sorry! I was just wanting to get your fixes.

And thank you, too!

[rfindler]

Sorry-- I pushed a commit that closed this issue but it isn't done.

[rfindler]

Forgot to mention it in the commit, but this fixes two more of them: racket/drracket@15e3a9a

[rfindler]

I think those two commits fix all the problems in drracket_unit.html.

[sorawee]

All fixed!