Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create initial CI workflow #111

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Create initial CI workflow #111

merged 1 commit into from
Oct 28, 2020

Conversation

pmatos
Copy link

@pmatos pmatos commented Oct 28, 2020

Builds htdp-test (and htdp-lib as dependent). Runs tests.

@pmatos
Copy link
Author

pmatos commented Oct 28, 2020

cc: @sorawee

@pmatos
Copy link
Author

pmatos commented Oct 28, 2020

I can see errors locally:

| raco setup:   /github/home/.racket/7.8/pkgs/htdp-lib/test-engine/test-markup.rkt:416:21: make-result: unbound identifier
| raco setup:     in: make-result
| raco setup:     compiling: <pkgs>/htdp-lib/test-engine/test-markup.rkt

Is this to be expected?

@sorawee
Copy link
Contributor

sorawee commented Oct 28, 2020

Yeah, this is the error that currently breaks Racket (I can't open DrRacket at all because of it). It's introduced in the latest commit (73d7458).

CC: @mikesperber

samth
samth reviewed Oct 28, 2020
View reviewed changes
.github/workflows/ci.yml Outdated
strategy:
fail-fast: false
matrix:
version: ['7.8', 'current']
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should either not test on 7.8 or allow it to fail (it wouldn't work currently).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed 7.8 from testing. Curious - why wouldn't 7.8 work?

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEAD needs changes to gui and DrRacket and a new package that's not part of 7.9 even.

Create initial workflow
45f427a 
Builds htdp-test (and htdp-lib as dependent). Runs tests.
@samth samth merged commit 0b47599 into racket:master Oct 28, 2020
@pmatos pmatos deleted the pmatos-ci branch October 28, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samth samth samth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmatos @sorawee @samth