Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combined failed and success status #9

Closed
zyrolasting opened this issue Feb 17, 2020 · 0 comments · Fixed by racket/racket-pkg-website#67
Closed

Combined failed and success status #9

zyrolasting opened this issue Feb 17, 2020 · 0 comments · Fixed by racket/racket-pkg-website#67

Comments

@zyrolasting
Copy link

zyrolasting commented Feb 17, 2020 •
edited

image

Package affected: unlike-assets as of Feb 16th. It had that status most of that day, if not all day.

The status links are by the bullet points below. I expect these links won't always resolve to the same document, so note that the failure link 404'd at this time of writing. However, it did earlier resolve to a very short error message that I do not recall (with apologies).

I'm assuming that this build actually succeeded since the 404 only applies to the failure log now.
bennn added a commit to bennn/racket-pkg-website that referenced this issue Feb 25, 2020
@bennn
avoid 'failssucceeds' status
96e9970 
If a package has a failure log and a success log, then ignore the
success and only show "fails" in the build summary.

fixes racket/pkg-build#9
@bennn bennn mentioned this issue Feb 25, 2020
Merged
jeapostrophe pushed a commit to racket/racket-pkg-website that referenced this issue Feb 25, 2020
@bennn @jeapostrophe
avoid 'failssucceeds' status
f9c3578 
If a package has a failure log and a success log, then ignore the
success and only show "fails" in the build summary.

fixes racket/pkg-build#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

avoid 'failssucceeds' status bennn/racket-pkg-website
1 participant
@zyrolasting