Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Regressions for 8.8 #4566

Closed
2 tasks done
jbclements opened this issue Feb 3, 2023 · 11 comments
Closed
2 tasks done

Release Regressions for 8.8 #4566

jbclements opened this issue Feb 3, 2023 · 11 comments
Labels
release-management Topics related to releases: regression, build failures for RCs, blocking issues, etc.

Comments

@jbclements
Copy link
Collaborator

jbclements commented Feb 3, 2023

Here are the current results for checking release regressions:

@sorawee
Copy link
Collaborator

sorawee commented Feb 3, 2023

crypto-test is due to #4532. We agree to revert the PR from both release and master.

@jbclements
Copy link
Collaborator Author

Oh, master too? Sounds good to me. In that case I can revert on master and cherry-pick it to the release, which feels nicer to me than reverting it on the release only and probably missing it in the next release.

@sorawee
Copy link
Collaborator

sorawee commented Feb 3, 2023

Yep, master too.

@samth
Copy link
Sponsor Member

samth commented Feb 3, 2023

Yes, I think we're going to abandon the hash-table changes entirely and make something new.

@jbclements
Copy link
Collaborator Author

@scolobb It looks like typed-compose is failing on the release build with an out-of-memory error during a package build. It also looks like the package is not failing on the master branch. Do you have any idea what's going on here?

@samth
Copy link
Sponsor Member

samth commented Feb 3, 2023

This is very unlikely to be @scolobb's fault. The release-pkg-build often has more timeouts than the regular pkg-build, since it's running more things in parallel and is on a different machine.

@jbclements
Copy link
Collaborator Author

I see. In that case, I'm going to check that one off as being complete. Let me know if you think that's not the right thing.

@jbclements
Copy link
Collaborator Author

Separately, I'm thinking we should wait until the release-pkg-build finishes next to make sure that crypto-test is now passing.

@scolobb
Copy link
Contributor

scolobb commented Feb 3, 2023

I hope @samth is right, because I don't have any idea how to go about debugging the kind of issue you are pointing out @jbclements 😄

@jbclements
Copy link
Collaborator Author

Yep, latest release-pkg-build shows crypto-test as no longer failing.

@jbclements
Copy link
Collaborator Author

Closing this as complete.

@shhyou shhyou added the release-management Topics related to releases: regression, build failures for RCs, blocking issues, etc. label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-management Topics related to releases: regression, build failures for RCs, blocking issues, etc.
Projects
None yet
Development

No branches or pull requests

5 participants