Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support images in check failure output #140

Merged
merged 3 commits into from Jul 7, 2021
Merged

Conversation

aymanosman
Copy link
Contributor

Fixes #130

This PR makes rackunit print values directly, as opposed to turning them into strings first.

@rmculpepper
Copy link
Contributor

When I try running the following program in DrRacket, I still get the picts printed as #<pict> in the output. Is it working for you?

#lang racket/base
(require pict rackunit)
(check-equal? (circle 10) (circle 20))

@aymanosman
Copy link
Contributor Author

You are right, thanks. I broke the implementation whilst fixing a merge conflict. Should be fixed now.

@rmculpepper rmculpepper merged commit b6f59fd into racket:master Jul 7, 2021
@samth
Copy link
Sponsor Member

samth commented Jul 8, 2021

rmculpepper added a commit that referenced this pull request Jul 13, 2021
- use pretty-print instead of pretty-write
- use port-count-lines! so pretty-printing works
- revert extra blank lines added by ce0ba9f
@samth
Copy link
Sponsor Member

samth commented Jul 20, 2021

This change broke the rackunit-fancy-runner rackunit-pretty-runner package, which was using the private info-value->string function. Would it make sense to restore that function using the new code written in this PR?

@aymanosman
Copy link
Contributor Author

@samth Can't seem to find that package anywhere.

@samth
Copy link
Sponsor Member

samth commented Jul 20, 2021

@samth
Copy link
Sponsor Member

samth commented Jul 20, 2021

I see that you couldn't find it because I wrote the wrong name, sorry about that!

aymanosman added a commit to aymanosman/rackunit that referenced this pull request Aug 4, 2021
unbreaks rackunit-fancy-runner

See racket#140 (comment)
samth pushed a commit that referenced this pull request Aug 6, 2021
unbreaks rackunit-fancy-runner

See #140 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to have rackunit render picts inside the "check-info stack"?
3 participants