tests: correctly test trim-current-directory #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that current-test-invocation-directory is set in parallel mode, this test case fails in DrDr environments with something like -------------------- trim-current-directory strips directory from files in current directory FAILURE name: check-equal? location: /opt/plt/builds/<current-rev>/trunk/racket/share/pkgs/rackunit-test/tests/rackunit/check-info-test.rkt:147:4 actual: "/opt/plt/builds/<current-rev>/trunk/racket/share/pkgs/rackunit-test/tests/rackunit/foo.rkt" expected: "foo.rkt" -------------------- -------------------- trim-current-directory leaves subdirectories alone FAILURE name: check-equal? location: /opt/plt/builds/<current-rev>/trunk/racket/share/pkgs/rackunit-test/tests/rackunit/check-info-test.rkt:152:4 actual: "/opt/plt/builds/<current-rev>/trunk/racket/share/pkgs/rackunit-test/tests/rackunit/foo/bar.rkt" expected: "foo/bar.rkt" -------------------- Instead of trying to make the tests deal with DrDr's environment, set the current-test-invocation-directory for these tests to the current-directory. In other words: when testing the tester, work around the (meta?) tester to be properly agnostic. Best viewed with: --ignore--all-space This should fixup problems with racket#175 (comment)
benknoble
force-pushed
the
fixup-check-info-test
branch
from
c309c93
to
9184a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that current-test-invocation-directory is set in parallel mode, this test case fails in DrDr environments with something like
Instead of trying to make the tests deal with DrDr's environment, set the current-test-invocation-directory for these tests to the current-directory. In other words: when testing the tester, work around the (meta?) tester to be properly agnostic.
Best viewed with: --ignore--all-space
This should fixup comments on #175 (comment).