scram: fix handling of bytes responses, add support for sha512 digests #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCRAM-SHA-512
isn't standardized, but it is used in the wild (eg. in Apache Kafka).I don't think there's much downside to allowing the extra digest.
The string change is a fix to make scram correctly support
sasl-receive-message
's contract, which is(or/c bytes? string?)
, whereas before this change it would fail if given abytes?
message.