Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defthing: use #:id expression instead of 'id' #161

Closed
wants to merge 1 commit into from

Conversation

bennn
Copy link
Contributor

@bennn bennn commented Feb 4, 2018

Change implementation of defthing so that if the user gives an id-expr via the #:id keyword, then defthing never uses the default id.

I think this is right, based on the docs. But maybe the docs should change.

cc @dedbox for reporting this


Example program:

#lang scribble/manual

@defthing[#:id (datum->syntax #f 'foo) dont-use integer?]{
  Something
}

Before this PR:
screen shot 2018-02-04 at 16 50 08

After this PR:
screen shot 2018-02-04 at 16 50 18

Change implementation of `defthing` so that if the user gives an
`id-expr` via the `#:id` keyword, then `defthing` never uses the default
`id`.
@bennn
Copy link
Contributor Author

bennn commented Mar 31, 2018

e2ea830

@bennn bennn closed this Mar 31, 2018
@bennn bennn deleted the defthing-id-kwd branch March 31, 2018 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant