-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for converting values to GIFs #232
Conversation
Manually tested this on my machine and it works. But I don't know how to write an automated test for this, or which places in the documentation need to be updated. Suggestions greatly appreciated! |
Looking at the existing tests, I don't see anything that tests any aspects of the html rendering. A number of places (core.scrbl, running.scrbl) seem to mention the supported formats. There's also the |
I see a |
Changed |
Ok by me. Is it worth extracting the GIF width and height to include as attributes in the |
Den tor. 21. maj 2020 kl. 05.07 skrev Sam Tobin-Hochstadt <
notifications@github.com>:
There's also the --convert flag, which should maybe also accept gif, and
the render-convertible-as property. I don't know if it makes sense to
change all these, but it might be worth looking at.
As far as I know, there is only one reason to use gifs namely to display
animations.
For all other purposes the existing image formats are better.
Therefore a general convert-to-gif option isn't worth it.
/Jens Axel
|
@mflatt Yes, that's a good idea. Will update the PR. |
@mflatt Done! |
Repairs a problem with racket#232. Relevant to racket/racket#3300.
Repairs a problem with racket#232. Relevant to racket/racket#3300.
Repairs a problem with #232. Relevant to racket/racket#3300. (cherry picked from commit 9415df2)
Closes #231. This pull request only touches the HTML rendering implementation code; it has no tests and does not yet update the docs. I'd like to get some feedback on whether this is the right implementation approach before getting to tests and docs.