Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of define-struct with struct #295

Closed

Conversation

jackfirth
Copy link
Sponsor Contributor

The define-struct form is a legacy form, struct is preferred in new code.

Note: these changes were automatically generated by resyntax.

The `define-struct` form is a legacy form, `struct` is preferred in new code.

Note: these changes were automatically generated by [`resyntax`](https://github.com/jackfirth/resyntax).
@samth
Copy link
Sponsor Member

samth commented Feb 12, 2021

I'm a bit skeptical that this is worth it since you are adding #:extra-constructor-name in every case. Is it possible to figure out which of those can be omitted?

@jackfirth
Copy link
Sponsor Contributor Author

jackfirth commented Feb 12, 2021

I think that ought to be possible, if trickier. It would require making more than one analysis pass over each module. I'll close this while I attempt to figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants