Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flush chunks to client after every iteration #44

Merged
merged 1 commit into from
Nov 9, 2018

Conversation

Bogdanp
Copy link
Sponsor Contributor

@Bogdanp Bogdanp commented Nov 9, 2018

This fixes an issue where, if the chunks of a chunked responses are too
short, they are never streamed to the client because they're buffered
within the OS socket.

A little more context here: https://racket.slack.com/archives/C06V96CKX/p1541782413390200

This fixes an issue where, if the chunks of a chunked responses are too
short, they are never streamed to the client because they're buffered
within the OS socket.
@jeapostrophe jeapostrophe merged commit b16fe0d into racket:master Nov 9, 2018
@jeapostrophe
Copy link
Contributor

Thank you!

@Bogdanp
Copy link
Sponsor Contributor Author

Bogdanp commented Nov 9, 2018

@jeapostrophe My pleasure! I think there's another bug here, though this one is less important. When the client closes the connection (user closes the tab, for example), the chunking loop tries to write to the socket and it fails with tcp-write: error writing. I don't think it's a huge deal, but it is a little noisy and may surprise folks who don't know what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants