This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Allow each webhook to override it's own channel #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,7 +31,6 @@ def initialize(config = {}) | |||
| @timeout = @config[:timeout] | |||
| @icon_emoji = @config[:icon_emoji] | |||
| @icon_url = @config[:icon_url] | |||
| @channel = @config[:channel] | |||
There was a problem hiding this comment.
this breaks backwards compatibility
There was a problem hiding this comment.
Any suggestions? I need per webhook channels.
There was a problem hiding this comment.
keep this in there and use this option if a webhook specific one is not given
|
Hello! I'd agree with @shortdudey123 that this should be a backwards-compatible change / feature enhancement. We should be able to support both the global webhook and a per-channel webhook, without breaking one another. Also, please don't bump the version in your PR. We can do that on release. |
modified to create handlers directory
modified to create handlers directory
changing the version from 0.9.0 to 0.9.1
changing the version from 0.9.0 to 0.9.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.