New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.2.0 of git cookbook conflicts with mysql cookbook LWRP #198
Comments
It appears to be a bug of the mysql cookbook, described at sous-chefs/mysql#328 and fixed in sous-chefs/mysql@93d6467. |
It seems like the main point of the upstream git cookbook is to aid in configuring a git server/daemon. I'd be okay with reverting to just using the package resource here. It seems the only interesting logic in the provider is configuring EPEL if the OS is old enough to not have a git package (RHEL/CentOS <= 5). My one concern is that by ditching the git cookbook, we're just playing whack-a-mole, since the actual defect (helper methods polluting other cookbooks) is from the mysql cookbook. I'd love to see it fixed at the root of the problem. |
RE: #198, pin back git cookbook while we figure out a longer-term path forward.
Good catch on EPEL for RHEL/CentOS 5, I completely overlooked that. Agreed that it appears to be fixed in newer versions. |
Looks like they released upstream to give us the fix backported to the versions we're using. sous-chefs/mysql#328 |
PS: The main point of the git cookbook (as far as I'm concerned) is to abstract package names and handle repo activation when needed on various platforms. https://github.com/jssjr/git/blob/master/libraries/helpers.rb#L3-L9 The service stuff can probably be removed... The recent refactor was just to shove recipes into resources as a start. -s |
Thanks all, especially for the additional context and clarification. This was resolved in sous-chefs/mysql#328 and I agree that leaving the git cookbook in is the best option to avoid that package naming weirdness. Closing this out. |
This is caused by https://github.com/chef-cookbooks/mysql/blob/v5.6.1/libraries/resource_mysql_service.rb#L58-L60
and https://github.com/jssjr/git/blob/4733ad3f574680f900c44eddffb6081ab4ca7106/libraries/helpers.rb#L11-L13 conflicting, from the look of it. Conflicting version 4.2.0 of the git cookbook was released yesterday.
Including the git::default recipe seems overkill just to install the package at https://github.com/rackspace-cookbooks/platformstack/blob/master/recipes/ohai_plugins.rb#L12 and nothing else. This dependency should be removed and replaced with a simple package install, unless there's some pressing reason not to.
The text was updated successfully, but these errors were encountered: