Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.11 root encrypt #71

Merged
merged 12 commits into from
Jun 11, 2020
Merged

V0.11 root encrypt #71

merged 12 commits into from
Jun 11, 2020

Conversation

dannyleesmith
Copy link
Contributor

Corresponding Issue(s):
Summary of change(s):
  • encrypt root volume at launch
  • allow KMS CMK for root and secondary volume
Reason for Change(s):

https://aws.amazon.com/about-aws/whats-new/2019/05/launch-encrypted-ebs-backed-ec2-instances-from-unencrypted-amis-in-a-single-step/

Will the change trigger resource destruction or replacement? If yes, please provide justification:

No

Does this update/change involve issues with other external modules? If so, please describe the scenario.

No

If input variables or output variables have changed or has been added, have you updated the README?

Done

Do examples need to be updated based on changes?

No

Note to the PR requester about Closing PR's

Please message the person that opened the issue when auto closing it on slack, as well as any other stake holders of deep interest. Only close the issue if you believe that the issue is fully resolved with this PR.

This PR may auto close the issue associated with it. If you feel the issue is not resolved please reopen the issue.

@dannyleesmith dannyleesmith changed the base branch from master to tf_v0.11 June 10, 2020 14:21
@dannyleesmith
Copy link
Contributor Author

Ran test locally with appropriate changes to work against test account:
main.tf.txt

Success:

Apply complete! Resources: 261 added, 0 changed, 0 destroyed.

Plan after shows 1 EIP association change but that does not seem to be because of anything in this module.

@johnctitus johnctitus merged commit 7aeeedb into tf_v0.11 Jun 11, 2020
@johnctitus johnctitus deleted the v0.11-root-encrypt branch June 11, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants