Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to latest tagged version #445

Closed
wants to merge 1 commit into from

Conversation

siwinski
Copy link
Contributor

@siwinski siwinski commented Nov 2, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 96480e2 on siwinski:pr-version-fix into 06b6592 on rackspace:working.

@ycombinator
Copy link
Contributor

Thank you for catching this! I can see at least 3 options on how to proceed:

  1. Merge this PR as-is into dev, then master. Do nothing more. This means the 1.11.0 version released on GitHub and packagist will continue to have the wrong value of VERSION (1.10.0).
  2. Modify the value of VERSION in this PR to 1.11.1. Merge the modified PR into dev, then master. Release a new patch version (1.11.1) on GitHub and packagist.
  3. We plan to release a new minor version (1.12.0) with some new features in a couple of weeks. When that happens, we will fix the value of VERSION to 1.12.0 and release on GitHub and packagist.

Thoughts? Is there an option 4 where we can modify the 1.11.0 release to include this PR?

/cc @gecampbell, @jamiehannaford

@siwinski
Copy link
Contributor Author

siwinski commented Nov 2, 2014

IMHO number 3 would be the way to go. It is up to you all though. I can update this PR to whatever you would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants