Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore older safari QUOTA_EXCEEDED_ERRs as well #223

Merged
merged 1 commit into from
Feb 4, 2016
Merged

Ignore older safari QUOTA_EXCEEDED_ERRs as well #223

merged 1 commit into from
Feb 4, 2016

Conversation

aaronjensen
Copy link
Contributor

Safari 5.1 throws a different error, without this history enabled sites don't work at all in safari private browsing.

@aaronjensen
Copy link
Contributor Author

Actually, now that scroll-behavior has updated to support history 2, it seems like the site does work, it just throws the quota error. So this isn't as bad, but it'd still be nice to handle both of these. Thanks!

@timdorr
Copy link
Member

timdorr commented Feb 4, 2016

LGTM. Thanks!

timdorr added a commit that referenced this pull request Feb 4, 2016
@timdorr
Merge pull request #223 from aaronjensen/fix-quota-error-for-safari-5
64c3956 
Ignore older safari QUOTA_EXCEEDED_ERRs as well
@timdorr timdorr merged commit 64c3956 into remix-run:master Feb 4, 2016
@renovate renovate bot mentioned this pull request Nov 23, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronjensen @timdorr @mjackson