-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: SonarLint support #8
Comments
Hi Roman, SonarSource is preventing all non-SonarSource products from being executed in SonarLint. Thus, unfortunately, you'll never see this CSS plugin in action in your IDE... David |
Hi @racodond, I know that you closed this issue about a year ago, but I wanted to ask if anything has changed since then. We use SonarQube for commenting on pull requests and use your Sonar CSS plugin extensively. What we have found is that the rules of this plugin tend to be violated the most in our team (but that is fine, we correct the code since we want it to be uniform). However, it would be extremely useful if we saw the rule violations prior to pull requests being created. We use the SonarLint plugin within Visual Studio for Windows and Visual Studio Code to warn us of rule violations for files other than CSS/SCSS. Adding support for CSS/SCSS support would be greatly advantageous to us since we would be able to see the rule violations within the editor. I have recently tried to modify the SonarLint plugin for Visual Studio Code, located here. It took very few changes to get it to download the latest .jar file from your repository and invoke it for .css and .scss files. However, SonarLint.Core complained that the CSS plugin (.jar) does not support SonarLint: Is this something that you could consider adding support for? |
Hi @Ivan-L , I think that there nothing that can be done on the side of the sonar-css-plugin. SonarLint is using this list to check is it possible to index and analyze the file. Unfortunately css or less is not included in the list so SonarLint will ignore them. As far as I know it had be done with purpose. There is a ticket on Sonar jira with a little explanation why it had be done https://jira.sonarsource.com/browse/SLCORE-65 So it's more on SonarLint side then on sonar-css-plugin. Hope it will help you |
Hi @Phoenix8095 , Yeah I managed to bypass the whitelist by adding However, I could not get further as the |
Hi guys, SonarSource do not want non-SonarSource plugins to run in SonarLint. So, they won't make it easy to hack. If they did want so, they would just have added a white list that could be extended in configuration. Regards, David |
I gave it one last shot and did manage to get the Continuing with the approach of setting the @Phoenix8095, you were right, modifying the whitelist to add a value of So in the end, the It is a pity. The SonarQube Issues Report plugin is also not working, so there is no way currently to see any CSS rule violations prior to doing a PR. I can only hope that SonarSource improve on this situation as this plugin is very useful and seeing the rule violations in the IDE or before a commit would definitely save time. |
Thanks for your investigation. But don't have vain hopes about SonarLint supporting non-SonarSource plugins... |
Hello @racodond |
Hi @Hilalem, The new sonar-css plugin developped by SonarSource is not linked to mine in any way. You should talk to SonarSource about your issue instead. David |
Hello, thank you very much Racodond
iPhone’umdan gönderildi
David RACODON <notifications@github.com<mailto:notifications@github.com>> şunları yazdı (17 Oca 2019 19:09):
Hi @Hilalem<https://github.com/Hilalem>,
The new sonar-css plugin developped by SonarSource is not linked to mine in any way. You should talk to SonarSource about your issue instead.
David
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#8 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Akept7sgVOoxKIjUTPf6dlz1rJ0TzkAVks5vEKAngaJpZM4NJ67Y>.
Bu mesaj ve ekleri, mesajda gonderildigi belirtilen kisi/kisilere ozeldir ve gizlidir. Bu mesajin muhatabi olmamaniza ragmen tarafiniza ulasmis olmasi halinde mesaj iceriginin gizliligi ve bu gizlilik yukumlulugune uyulmasi zorunlulugu tarafiniz icin de soz konusudur. Mesaj ve eklerinde yer alan bilgilerin dogrulugu ve guncelligi konusunda gonderenin ya da sirketimizin herhangi bir sorumlulugu bulunmamaktadir. Sirketimiz mesajin ve bilgilerinin size degisiklige ugrayarak veya gec ulasmasindan, butunlugunun ve gizliliginin korunamamasindan, virus icermesinden ve bilgisayar sisteminize verebilecegi herhangi bir zarardan sorumlu tutulamaz.
This message and attachments are confidential and intended solely for the individual(s) stated in this message. If you received this message although you are not the addressee, you are responsible to keep the message confidential. The sender has no responsibility for the accuracy or correctness of the information in the message and its attachments. Our company shall have no liability for any changes or late receiving, loss of integrity and confidentiality, viruses and any damages caused in anyway to your computer system.
|
Hello,
SonarLint is an extension for IDE that provides on-the-fly feedback directly in IDE.
But sonar css plugin doesn't support SonarLint extension.
Does anyone know the reason why css plugin doesn't support SonarLint extension ?
Is it possible to add this support ?
I haven't found any discussion about this so I'm just wondering if any work has been done for this.
Thanks,
Roman
The text was updated successfully, but these errors were encountered: