Added Music made by Unsigned Arduino #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just added the music into here
ractive
requested changes
Mar 11, 2021
| } else { return } | ||
| } | ||
| music.stopAllSounds() | ||
| function play_note(freq: number, length: number, key_number: number, from_color: number, to_color: number) { |
There was a problem hiding this comment.
key_number, from_color and to_color are not used. 🤔
Names in JavaScript/TypeScript are always camelCase, so this function would be called playNote.
There was a problem hiding this comment.
Btw I did not make most of the code, I mostly just injected it into the game.
| function play_note(freq: number, length: number, key_number: number, from_color: number, to_color: number) { | ||
| music.playTone(freq, length) | ||
| } | ||
| play_song() |
| @@ -11,7 +11,2468 @@ Players.addPlayerOne(); | |||
| if (twoPlayerMode) { | |||
| Players.addPlayerTwo(); | |||
| } | |||
|
|
|||
| if (game.ask("Do you want Music?", "May Increase Lag")) { | |||
| let stop_music: boolean = false | |||
There was a problem hiding this comment.
How is this flag ever set to true?
|
|
||
| timer.background(function() { | ||
| function play_song() { | ||
| stop_music = false |
There was a problem hiding this comment.
The indendation is broken from here on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added the music into here. It is made optional for lag purposes.