Merge branch 'gh-3294' into dev

ractivejs · Feb 4, 2019 · 90a00c7 · 90a00c7
2 parents cb374fc + 1774347
commit 90a00c7
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/view/items/element/binding/CheckboxNameBinding.js b/src/view/items/element/binding/CheckboxNameBinding.js
@@ -68,7 +68,7 @@ export default class CheckboxNameBinding extends Binding {
 
   handleChange() {
     this.isChecked = this.element.node.checked;
-    this.group.value = this.model.get();
+    this.group.value = this.model.get().slice();
     const value = this.element.getAttribute('value');
     if (this.isChecked && !this.arrayContains(this.group.value, value)) {
       this.group.value.push(value);

diff --git a/tests/browser/twoway.js b/tests/browser/twoway.js
@@ -1711,4 +1711,27 @@ export default function() {
     inputs = r.findAll('input');
     t.ok(inputs[0].checked && !inputs[1].checked);
   });
+
+  test('Old and new values should be set correctly with named checkbox bindings (#3293)', t => {
+    const ractive = new Ractive({
+      el: fixture,
+      template: `
+        <input type="checkbox" id="red" name="{{colors}}" value="red" />
+        <input type="checkbox" id="green" name="{{colors}}" value="green" /> `,
+      data: { colors: ['green'] }
+    });
+
+    ractive.observe(
+      'colors',
+      (newValue, oldValue) => {
+        t.deepEqual(newValue, ['green', 'red'], 'new value should be correct');
+        t.deepEqual(oldValue, ['green'], 'old value should be correct');
+      },
+      {
+        init: false
+      }
+    );
+
+    fire(ractive.find('#red'), 'click');
+  });
 }