Fix enhance & append conflict check #3216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Preface: We should not use
enhance: true
andappend: true
at the same time, so Ractive checks for this case and throws an error if we misbehave.However, if we use
Ractive.defaults.enhance = true;
and create a Ractive instance withappend: true
, Ractive fails to throw an error.That's because here
we're using the
options
object to check for the conflicting case. I guess we should usetarget
instead ofoptions
to do this.Is breaking:
It was breaking the
Cannot use append and enhance at the same time
test inenhance.js
becauseoptions.enhance
was not getting copied intotarget
. And that's because thedefaults
object does not includeenhance
. That's why I added that in 4bdefbd.