This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
Update to 1.4.1 release of origin #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes results of "gofmt -w". Modify the code to work against origin 1.4.1. The major change here is that scaling must be done against the deploymentconfig and not the replication controller.
|
this worked for me from the rest build, but i'm not sure about the travis tests here. were they ever working? |
|
tested through both -cli and -rest, everything worked. |
|
I'm pretty sure that the travis tests have never worked. There isn't even a .travis.yml defined. Are there tests that could be run? It would be a pretty simple .travis.yml, most likley. |
|
Yeah, travis has never been fixed up. Hardly worth it at this point if we're going to merge repos. |
This was referenced Mar 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes results of "gofmt -w". Modify the code to work against
origin 1.4.1. The major change here is that scaling must be
done against the deploymentconfig and not the replication
controller.