Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radiff2 dot generates invalid output #14900

Closed
XVilka opened this issue Aug 26, 2019 · 3 comments
Closed

radiff2 dot generates invalid output #14900

XVilka opened this issue Aug 26, 2019 · 3 comments
Assignees
Milestone

Comments

@XVilka
Copy link
Contributor

XVilka commented Aug 26, 2019

Seems it doesn't filter the colors from the dot output, or not convert them into the dot format

radiff2 -g main -m d /bin/false /bin/true | xdot -

Then xdot returns an error.

@deepakchethan
Copy link
Contributor

Yep, able to reproduce, working on it now.

deepakchethan added a commit to deepakchethan/radare2 that referenced this issue Aug 26, 2019
@XVilka XVilka closed this as completed in 64c0157 Aug 27, 2019
@XVilka
Copy link
Contributor Author

XVilka commented Aug 27, 2019

@deepakchethan it wasn't properly fixed yet. While xdot doesn't return an error, the output is still rubbish:
image

@XVilka XVilka reopened this Aug 27, 2019
@deepakchethan
Copy link
Contributor

I think this is because I recently enabled color for the ascii graphs, its a one line fix. Will do it, I'm sorry about it :)

deepakchethan added a commit to deepakchethan/radare2 that referenced this issue Aug 27, 2019
@radare radare closed this as completed in d85b55c Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants