Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in LOAD segment vaddr handling #6650

Closed
SchumBlubBlub opened this issue Feb 3, 2017 · 12 comments
Closed

Regression in LOAD segment vaddr handling #6650

SchumBlubBlub opened this issue Feb 3, 2017 · 12 comments

Comments

@SchumBlubBlub
Copy link
Contributor

https://github.com/radare/radare2-regressions/pull/691

$ rabin2 -S bin | grep LOAD0
idx=28 vaddr=0x00400000 paddr=0x00000000 sz=8796 vsz=8796 perm=m-r-x name=LOAD0
$ r2 -qc 'iS' -d bin | grep LOAD0
idx=28 vaddr=0x00000000 paddr=0x00000000 sz=8796 vsz=8796 perm=m-r-x name=LOAD0

lose the vaddr for the segment and r2 iS doesnt meet rabin2 out.

broken by 4fd1e99

@SchumBlubBlub
Copy link
Contributor Author

wait, this is even worse. It's not just this mangled elf that's the problem. I can't db main on a "hello world" program anymore. 🔥 .

@radare
Copy link
Collaborator

radare commented Feb 3, 2017 via email

@leberus
Copy link
Contributor

leberus commented Feb 3, 2017

my fault, i'll check it out now

@radare radare added this to the 1.3.0 milestone Feb 3, 2017
@Maijin
Copy link
Contributor

Maijin commented Feb 3, 2017

There is also e dbg.bep variable that you can set to main

@SchumBlubBlub
Copy link
Contributor Author

I tried dcu a while ago, its was really slow getting out of the loader and into main, I had to break.

@leberus
Copy link
Contributor

leberus commented Feb 3, 2017

I've found it:

+#define R_IO_PRIV (1 « 5)
+#define R_IO_SHAR (1 « 6)

This breaks it. I'll check how to make that it doesn't collide

@SchumBlubBlub
Copy link
Contributor Author

There is also e dbg.bep variable that you can set to main

@Maijin , I did, that's how I met this bug.

leberus added a commit to leberus/radare2 that referenced this issue Feb 3, 2017
@leberus
Copy link
Contributor

leberus commented Feb 9, 2017

I think this can be closed. It was solved by 6672, wasn't it?

@radare radare closed this as completed Feb 9, 2017
@radare
Copy link
Collaborator

radare commented Feb 9, 2017

do we have tests?

@leberus
Copy link
Contributor

leberus commented Feb 9, 2017

I promise i'll write some tests for the debugger

@Maijin
Copy link
Contributor

Maijin commented Feb 9, 2017

@SchumBlubBlub
Copy link
Contributor Author

SchumBlubBlub commented Feb 9, 2017

Tests: link in OP, Maijin just merged: https://github.com/radare/radare2-regressions/pull/691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants