Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References should specify the access type #7094

Closed
3 tasks
radare opened this issue Mar 23, 2017 · 12 comments
Closed
3 tasks

References should specify the access type #7094

radare opened this issue Mar 23, 2017 · 12 comments
Assignees
Milestone

Comments

@radare
Copy link
Collaborator

radare commented Mar 23, 2017

This information shuold be extracted from the referencing instruction. For data references:

  • READ mov ax, [0x800]
  • WRITE mov [0x800], ax
  • REF lea ax, [0x800]

As for namings 'READ' can be 'r', WRITE can be 'w', and REF.. can be PTR this is 'p'. The access type for all the cod refs should be exec.

In addition to the CALL JMP .. refs which should be of type EXEC

What's left:

  • Define command syntax to set that information in the Ref struct
  • Update the output of the ax commands to show that information
  • Verify the correctness of the results

Those only make sense to be for axd and axs (data references), but ideally will be good to have it working for any for proper flexibility.

So my proposal is to add a 3rd argument specifying the access type:

  • axd 0x808080 0x303030 w
  • axd 0x808060 0x303030 r
@radare radare added this to the 1.4.0 milestone Mar 23, 2017
@radare radare added the RAnal label Mar 23, 2017
@radare radare modified the milestones: 1.5.0, 1.4.0 Mar 26, 2017
@Maijin
Copy link
Contributor

Maijin commented Mar 27, 2017

#7120

@radare radare modified the milestones: 1.6.0, 1.5.0 May 27, 2017
@radare radare modified the milestones: 1.7.0, 1.6.0 Jul 9, 2017
@XVilka XVilka modified the milestones: 1.7.0, 1.8.0 Oct 4, 2017
@radare
Copy link
Collaborator Author

radare commented Oct 16, 2017

Initial work done in 986ab7a

@rlaemmert rlaemmert removed their assignment Nov 10, 2017
@radare radare modified the milestones: 2.1.0, 2.3.0 Nov 24, 2017
@radare radare modified the milestones: 2.3.0, 2.4.0 Jan 28, 2018
@radare radare modified the milestones: 2.4.0, 2.6.0 Feb 27, 2018
@radare
Copy link
Collaborator Author

radare commented May 10, 2018

related to the xrefs rework you did

@radare
Copy link
Collaborator Author

radare commented Apr 5, 2019

ghidra copied us for being lazy
IMAGE 2019-04-06 00:02:27

@radare
Copy link
Collaborator Author

radare commented Apr 11, 2019

another proof that the nsa snitch on us :P

Screenshot 2019-04-11 at 14 37 27

@radare radare modified the milestones: 3.5.0, 3.6.0 May 9, 2019
@radare radare modified the milestones: 3.6.0, 3.7.0 Jun 17, 2019
@radare radare modified the milestones: 3.7.0, 3.8.0 - after r2con Jul 31, 2019
@XVilka XVilka modified the milestones: 3.9.0, 4.0.0 Sep 14, 2019
@radare radare modified the milestones: 4.0.0, 4.1.0 Oct 28, 2019
@radare
Copy link
Collaborator Author

radare commented Jan 17, 2020

we cannot delay more this feature

@XVilka XVilka modified the milestones: 4.3.0, 4.5.0 Mar 2, 2020
@XVilka XVilka modified the milestones: 4.5.0 - Organized Chaos, 4.6.0 May 21, 2020
@ret2libc ret2libc removed this from the 4.6.0 milestone Jul 17, 2020
@whoami-defnotme
Copy link

Just dug this issue up and I think it would be great to see this land. It'd be valuable to do things like "find all write references to the DATA section of my target binary."

@trufae trufae added this to the 5.7.0 milestone Apr 9, 2022
@trufae trufae assigned trufae and unassigned radare Apr 9, 2022
@trufae trufae closed this as completed in 59f9681 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants