Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fcn name in Visual mode if necessary when asm.filter=false and asm.jmpsub=false #14713

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

kazarmy
Copy link
Contributor

@kazarmy kazarmy commented Jul 31, 2019

Before:
before_no_filter_fcn_name

After:
after_no_filter_fcn_name

@radare
Copy link
Collaborator

radare commented Jul 31, 2019

thats why i was asking for a screenshot. ihave the feeling that at som epoint we will need to do another huge refactoring in this disasm.c

@kazarmy
Copy link
Contributor Author

kazarmy commented Jul 31, 2019

thats why i was asking for a screenshot.

well the screenshot wouldn't have helped since i don't usually set the 2 config vars to false ... but i did manage to remember you asking me about this particular configuration

ihave the feeling that at som epoint we will need to do another huge refactoring in this disasm.c

it's still manageable ... it's basically about ordering and coordinating the disasm pipeline stages properly

@radare radare merged commit 2584764 into radareorg:master Jul 31, 2019
@radare
Copy link
Collaborator

radare commented Jul 31, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants