Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asm.calls final tweakings / bug fixes #5765

Merged
merged 4 commits into from Sep 15, 2016
Merged

Conversation

oddcoder
Copy link
Contributor

No description provided.

for (i = 0; i < arg_max; i++) {
char *type = r_anal_type_func_args_type (anal, name, i);
r_cons_printf ("%s%s%s%s%s", i == 0 ? "": " ", type,
type[strlen (type) -1] == '*' ? "": " ",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be index -1

i == arg_max - 1 ? ");\n": ",");
free (type);
if (arg_max == 0) {
r_cons_printf("void);\n");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

}
arg_bp = true;
r_cons_printf ("%s%s%s%s", var->type,
var->type[strlen (var->type) - 1] =='*' ? "" : " ",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index -1

bool arg_bp = false;
r_list_foreach (regs, iter, var) {
r_cons_printf ("%s%s%s%s", var->type,
var->type[strlen (var->type) - 1] =='*' ? "" : " ",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index can be -1

@oddcoder
Copy link
Contributor Author

They are all fixed, github fault

@oddcoder
Copy link
Contributor Author

Fixing broken tests here
https://github.com/radare/radare2-regressions/pull/546

@radare radare merged commit 0b0f20c into radareorg:master Sep 15, 2016
@oddcoder oddcoder deleted the asm.calls branch January 29, 2017 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants