Fix kill of the debuggee

[giuscri]

Error introduced while trying to fix #9410
pid, tid should be allowed to be zero too, afaik.

[radare]

why?

     If pid is zero:
             Sig is sent to all processes whose group ID is equal to the
             process group ID of the sender, and for which the process has
             permission; this is a variant of killpg(2).

[giuscri]

oh. that means the parent process too - r2?

codebase is using this thing though:

binr/radare2/radare2.c:1393:							r_debug_kill (r.dbg, 0, false, 9); // KILL
binr/radare2/radare2.c:1399:								r_debug_kill (r.dbg, 0, false, 9); // KILL
binr/radare2/radare2.c:1422:					r_debug_kill (r.dbg, 0, false, 9); // KILL

[XVilka]

What to do with this one?

[giuscri]

Using pid=0 worked before eef9406 as gid of who launched r2 and who launched attached process is the same in most r2 usages.

Note that after that kill r2 was killed too but that was not a problem as you were already returning from main. You were skipping some free()s though.

[giuscri]

Calling r_debug_kill with pid,tid of attached process should fix this error

Do you want to quit? (Y/n)
Do you want to kill the process? (Y/n)
Backend does not implement kill()

without using pid,tid of 0.

I've updated this PR with fc46aa1

[radare]

Yes but attaching to gdb and then swithcing to native profile was causing a kill on all your local programs :p

…

On 27 Feb 2018, at 12:00, Giuseppe ***@***.***> wrote: Using pid=0 worked before eef9406 as gid of who launched r2 and who launched attached process is the same in most r2 usages. Note that after that kill r2 was killed too but that was not a problem as you were already returning from main. You were skipping some free()s though. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.