Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radare/radare2 issue #4173 - initial fix #107

Closed
wants to merge 1 commit into from

Conversation

jarusified
Copy link

No description provided.

@jarusified jarusified changed the title issue #4173 - initial fix radare/radare2 issue #4173 - initial fix Mar 22, 2016
cl = RapClient("localhost", 9999)
cl.cmd(line)

threading.Thread(target=threaded_client, args=(line.strip(), )).start()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would prefer not to create threads from this library, this can be delegated to the user who uses the api.

@jarusified
Copy link
Author

yes ofcourse, i did this just to test the working.

@radare
Copy link
Collaborator

radare commented Mar 24, 2016

Is threading necessary?

On 23 Mar 2016, at 10:58, suraj jarus notifications@github.com wrote:

yes ofcourse, i did this just to test the working.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub

@jarusified
Copy link
Author

Nopes, not required. Instead of writing client API directly, I`` thought we could test with the already existing API. So I create a separate instance of client everytime there is an input to the stdin and disconnect once it is parsed.

@radare
Copy link
Collaborator

radare commented Mar 24, 2016

it will be cool to package the rap.py api into pip, as its already done for r2pipe too

@radare
Copy link
Collaborator

radare commented Apr 3, 2016

ping

@radare radare closed this May 11, 2016
@radare
Copy link
Collaborator

radare commented May 11, 2016

timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants